Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Differentiate between failures to load config file not existing vs. parse errors #242

Merged
merged 5 commits into from
Aug 22, 2019
Merged

Differentiate between failures to load config file not existing vs. parse errors #242

merged 5 commits into from
Aug 22, 2019

Conversation

timfpark
Copy link
Contributor

@timfpark timfpark commented Aug 22, 2019 •
edited
Loading

Fixes #241

@timfpark timfpark mentioned this pull request Aug 22, 2019
Closed
@timfpark timfpark requested review from evanlouie and edaena August 22, 2019 15:11
evanlouie
evanlouie suggested changes Aug 22, 2019
View reviewed changes
core/componentConfig.go Outdated Show resolved Hide resolved
core/componentConfig.go Outdated Show resolved Hide resolved
@timfpark
Copy link
Contributor Author

@evanlouie Fixed your style changes - but also added checks during component loading since we don't want to hide parse failures there either.

evanlouie
evanlouie approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@evanlouie evanlouie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@timfpark timfpark merged commit ac02389 into microsoft:master Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanlouie evanlouie evanlouie approved these changes

@edaena edaena edaena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid YAML removes most of the content of HLD
3 participants
@timfpark @edaena @evanlouie